[coreboot-gerrit] Change in coreboot[master]: soc/amd/common/lpc: Add SuperIO decode function

[Richard Spiegel (Code Review)]

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35271 )

Change subject: soc/amd/common/lpc: Add SuperIO decode function
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35271/1/src/soc/amd/common/block/in... 
File src/soc/amd/common/block/include/amdblocks/lpc.h:

https://review.coreboot.org/c/coreboot/+/35271/1/src/soc/amd/common/block/in... 
PS1, Line 78: #define     DECODE_SIO_4E4F		1
> I'm OK with redefining the 4e4f and 2e2f values. […]

At least add the comment indicating that these 2 values refer to the bit that needs to be set (from DECODE_ALTERNATE_SIO_ENABLE and DECODE_SIO_ENABLE)