[coreboot-gerrit] Change in coreboot[master]: payloads/tianocore: Enable UEFIPayload

[Lance Zhao (Code Review)]

Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34459 )

Change subject: payloads/tianocore: Enable UEFIPayload
......................................................................

Patch Set 11:

(4 comments)

https://review.coreboot.org/c/coreboot/+/34459/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34459/1//COMMIT_MSG@13 
PS1, Line 13: TEST=Able to build with tianocore debug and release build.
> What about boot-testing tianocore? I don't think build-testing is enough testing for this change.

Done

https://review.coreboot.org/c/coreboot/+/34459/5//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34459/5//COMMIT_MSG@14 
PS5, Line 14: origin/master
> > origin/master […]

Done

https://review.coreboot.org/c/coreboot/+/34459/5//COMMIT_MSG@14 
PS5, Line 14: revision to origin/master. Then build and able to boot up on QEMU q35
> I guess because currently MrChromebox’ repository is used? https://github. […]

Done

https://review.coreboot.org/c/coreboot/+/34459/9/payloads/external/tianocore... 
File payloads/external/tianocore/Kconfig:

https://review.coreboot.org/c/coreboot/+/34459/9/payloads/external/tianocore... 
PS9, Line 42: depends on TIANOCORE_UEFIPAYLOAD
> this should be removed, both payload options should be able to set a specific revision

Done