build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29065 )
Change subject: cpu/amd: Use common AMD's MSR
......................................................................
Patch Set 24:
(3 comments)
https://review.coreboot.org/#/c/29065/24/src/cpu/amd/family_10h-family_15h/d...
File src/cpu/amd/family_10h-family_15h/defaults.h:
https://review.coreboot.org/#/c/29065/24/src/cpu/amd/family_10h-family_15h/d...
PS24, Line 77: { NB_CFG_MSR, (AMD_FAM10_ALL | AMD_FAM15_ALL), AMD_PTYPE_DC | AMD_PTYPE_MC,
line over 80 characters
https://review.coreboot.org/#/c/29065/24/src/cpu/amd/family_10h-family_15h/d...
PS24, Line 107: 1 << 21, 0x00000000 }, /* Erratum #254 DR B1 BU_CFG_MSR[21]=1 */
line over 80 characters
https://review.coreboot.org/#/c/29065/24/src/cpu/amd/family_10h-family_15h/d...
PS24, Line 118: { CPU_ID_FEATURES_MSR, (AMD_FAM10_ALL | AMD_FAM15_ALL), AMD_PTYPE_DC | AMD_PTYPE_MC,
line over 80 characters
--
To view, visit
https://review.coreboot.org/29065
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0236e0960cd1e79558ea50c814e1de2830aa0550
Gerrit-Change-Number: 29065
Gerrit-PatchSet: 24
Gerrit-Owner: Elyes HAOUAS
ehaouas@noos.fr
Gerrit-Reviewer: Elyes HAOUAS
ehaouas@noos.fr
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Comment-Date: Thu, 18 Oct 2018 07:35:25 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No