Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49059 )
Change subject: mb/{google,intel}/*: select SOC_INTEL_CSE_LITE_SKU only if CHROMEOS
......................................................................
Patch Set 1:
Patch Set 1:
I'm not convinced that the dependency on CHROMEOS is correct. Mapped
to reality that would imply that one switches the CSE SKU when switching
CHROMEOS off?
I'm inclined to agree. Looking at cse_lite.c, it would seem there's an implicit dependency on vboot, not necessarily ChromeOS. Dropping 'depends on CHROMEOS' from SOC_INTEL_CSE_LITE_SKU would allow certain boards to build w/o CHROMEOS selected, but not sure that would result in a bootable image
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49059
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6959f35e1285b2fab7ea1f83a5ccfcb065c12397
Gerrit-Change-Number: 49059
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 03 Jan 2021 23:27:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment