Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40015 )
Change subject: soc/amd/common/psp: Move definitions into a private file
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/40015/2/src/soc/amd/common/block/ps...
File src/soc/amd/common/block/psp/psp.c:
https://review.coreboot.org/c/coreboot/+/40015/2/src/soc/amd/common/block/ps...
PS2, Line 25: #include "psp_def.h"
nit: Maybe put the "" includes below the <> includes ?
+1
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40015
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2fb0ed1d2697c313fb8475e3f00482899e729130
Gerrit-Change-Number: 40015
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Marshall Dawson
marshall.dawson@amd.corp-partner.google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 01 Apr 2020 16:04:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment