[coreboot-gerrit] Change in coreboot[master]: herobrine: sc7280: Provide initial mainboard support

[Shelley Chen (Code Review)]

Attention is currently required from: Ravi kumar, Paul Menzel, Ravi Kumar Bokka, Julius Werner, mturney mturney.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45206 )

Change subject: herobrine: sc7280: Provide initial mainboard support
......................................................................

Patch Set 32:

(5 comments)

File src/mainboard/google/herobrine/Kconfig:

https://review.coreboot.org/c/coreboot/+/45206/comment/71344d88_386aa39e 
PS6, Line 40: 	default 0xa
> DRIVER_TPM_SPI_BUS and EC_GOOGLE_CHROMEEC_SPI_BUS […]

Ok, let's follow Julius' advice and not define these yet then.

File src/mainboard/google/herobrine/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/45206/comment/529c95b2_103cf8f7 
PS32, Line 3: bootblock-y += boardid.c
I believe that Julius brought up earlier that you can use `all-y += reset.c` as a shorthand for adding it to each stage individually.  I saw the comment had been resolved but I don't see the changes here.

File src/mainboard/google/herobrine/board.h:

https://review.coreboot.org/c/coreboot/+/45206/comment/efdac2bf_e5558b08 
PS32, Line 3: TROGDOR
HEROBRINE

https://review.coreboot.org/c/coreboot/+/45206/comment/9400722a_84271166 
PS32, Line 4: TROGDOR
HEROBRINE

https://review.coreboot.org/c/coreboot/+/45206/comment/c8a06ce9_68886241 
PS32, Line 11: TROGDOR
HEROBRINE