build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38981 )
Change subject: xeonsp/skylake-sp: Add FSP SiliconInit invocation ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38981/2/src/cpu/intel/xeonsp/cpu/sk... File src/cpu/intel/xeonsp/cpu/skylake-sp/chip.c:
https://review.coreboot.org/c/coreboot/+/38981/2/src/cpu/intel/xeonsp/cpu/sk... PS2, Line 67: if (dev->path.type == DEVICE_PATH_DOMAIN) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/c/coreboot/+/38981/2/src/cpu/intel/xeonsp/cpu/sk... PS2, Line 70: else if (dev->path.type == DEVICE_PATH_CPU_CLUSTER) { else should follow close brace '}'