Attention is currently required from: Martin Roth, Jeremy Soller.
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47768 )
Change subject: mb/system76/oryp6: Add System76 Oryx Pro 6
......................................................................
Patch Set 15:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/47768/comment/4fb55c23_4bb9a48d
PS15, Line 32: - S3 suspend/resume
What happens when trying to suspend/resume?
I didn't dig into it too much: It hangs on resume. If I enable coreboot logging (through our EC logging), then it resumes successfully.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47768
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If017d65ca6cb36fe1f631d4dadd050a1547c93fa
Gerrit-Change-Number: 47768
Gerrit-PatchSet: 15
Gerrit-Owner: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Comment-Date: Mon, 26 Apr 2021 16:40:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment