Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34411 )
Change subject: soc/intel: Expand SA_DEV_ROOT for ramstage
......................................................................
Patch Set 3:
Patch Set 3:
Missed a weird SA_DEV_ROOT in `mainboard/purism/librem_skl/hda_verb.c`
maybe more? didn't check.
The bad thing: The compiler doesn't warn about the conversion from
integer to pointer without a cast, because SA_DEV_ROOT is literally
`0` and there seems to be an exception for that conversion.
CB:34544
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34411
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I298f7f9a1c6a64cfba454e919eeaedc7bb2d4801
Gerrit-Change-Number: 34411
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Wed, 24 Jul 2019 10:01:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment