Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37514 )
Change subject: soc/intel/skylake: Add option to control microcode update inclusion ......................................................................
Patch Set 4: Code-Review+2
Patch Set 4:
Patch Set 3: Code-Review-1
(1 comment)
The current approach implies that users can't change that behavior without editing Kconfig files. I'd rather have an option in menuconfig to only include microcode updates for a specific CPUID, that can be used with any mainboard. Those who squeeze Linux kernels into flash chips next to coreboot like extra space, so even desktop boards with socketed CPUs could use this idea.
There is no need to edit Kconfig to change the behavior. The items show up in menuconfig. If the board contains a PCH_H the only options that show are Skylake and Kabylake as those are the only two possibilities.
In the other case (with the LP) there are 3 possibilities:
- Skylake
- Kabylake with 2 or 4 cores.
I didn't use the CPUID but the descriptions ("Skylake", "Kaby Lake DUAL" and "Kaby Lake QUAD") as this is obvious immediately and doesn't require to dig into the datasheet to find the CPUID.
Oh, missed that the Kconfig options you added have a prompt. My bad.