Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34656 )
Change subject: src/soc/intel/cannonlake: Configure top swap based on ucode version
......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34656/6/src/soc/intel/cannonlake/bo...
File src/soc/intel/cannonlake/bootblock/cpu.c:
https://review.coreboot.org/c/coreboot/+/34656/6/src/soc/intel/cannonlake/bo...
PS6, Line 36: cpu_id = cpu_get_cpuid();
you don't use cpu_id
updated the code
https://review.coreboot.org/c/coreboot/+/34656/6/src/soc/intel/cannonlake/bo...
PS6, Line 51: G
no need for C preprocessor
updated the code
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34656
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0ed2ca9e350acf0385ce5d790d319235df6c9f21
Gerrit-Change-Number: 34656
Gerrit-PatchSet: 9
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 30 Aug 2019 08:38:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment