Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47309 )
Change subject: mb/google/zork: Add func to determine fingerprint gpio init
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47309/4/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/baseboard/helpers.c:
https://review.coreboot.org/c/coreboot/+/47309/4/src/mainboard/google/zork/v...
PS4, Line 157: }
: return 0;
bad rebase?
Yah. Thanks!
https://review.coreboot.org/c/coreboot/+/47309/4/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/morphius/variant.c:
https://review.coreboot.org/c/coreboot/+/47309/4/src/mainboard/google/zork/v...
PS4, Line 20: /* All Morphius SKUs have a fingerprint sensor */
Morphius is actually with both FP & non-FP SKUs.
Updated comment.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47309
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia5200e3bcfe3a2beac9b3b6d7803aeac9dfc59e6
Gerrit-Change-Number: 47309
Gerrit-PatchSet: 5
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Keith Tzeng
keith.tzeng@quanta.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Peichao Wang
pwang12@lenovo.corp-partner.google.com
Gerrit-Comment-Date: Tue, 10 Nov 2020 18:45:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Keith Tzeng
keith.tzeng@quanta.corp-partner.google.com
Gerrit-MessageType: comment