Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42504 )
Change subject: mb/google/volteer: Disable D3Cold along with pass through mode
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42504/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42504/4//COMMIT_MSG@7
PS4, Line 7: Disable D3Cold
XHCI can only have D3Hot support. […]
Sorry, I meant can you change the wording to say "D3cold for TCSS" or something like that.
https://review.coreboot.org/c/coreboot/+/42504/4//COMMIT_MSG@12
PS4, Line 12: needed
need
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42504
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I98ed991e4185abf1f3168e33b099e0e97c9075f6
Gerrit-Change-Number: 42504
Gerrit-PatchSet: 4
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Divya S Sasidharan
divya.s.sasidharan@intel.com
Gerrit-Reviewer: Divya Sasidharan
divya.s.sasidharan@intel.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Shamile Khan
shamile.khan@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Prashant Malani
pmalani@chromium.org
Gerrit-CC: Tanu Malhotra
tanu.malhotra@intel.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Fri, 19 Jun 2020 20:52:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: John Zhao
john.zhao@intel.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment