Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31518 )
Change subject: vendorcode/siemens: Save currently open hwi file name
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Nice!
https://review.coreboot.org/#/c/31518/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31518/2//COMMIT_MSG@7
PS2, Line 7: Save
Maybe even *Cache*?
s/open/opened/ though I am not sure about that.
https://review.coreboot.org/#/c/31518/2//COMMIT_MSG@15
PS2, Line 15: which saves execution time
Could you please add hard numbers for your platforms?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31518
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id69e0f6c914c2b8e4551fd8a4fb7d452d176afb3
Gerrit-Change-Number: 31518
Gerrit-PatchSet: 2
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Uwe Poeche
uwe.poeche@siemens.com
Gerrit-Comment-Date: Thu, 21 Feb 2019 15:43:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment