29 May
2020
29 May
'20
1:32 a.m.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41732 )
Change subject: drivers/vpd: add VPD region VPD_RW_THEN_RO ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41732/3/src/drivers/vpd/vpd.c File src/drivers/vpd/vpd.c:
https://review.coreboot.org/c/coreboot/+/41732/3/src/drivers/vpd/vpd.c@215 PS3, Line 215: region != VPD_RW changed my mind - give we have so many cases now, let's do an explicit list here so people will be easier to figure out what how this will be executed. e,g,
(region == VPD_RO || region == VPD_RO_THEN_RW || region == VPD_RW_THEN_RO)
--
To view, visit https://review.coreboot.org/c/coreboot/+/41732
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icd7cbd9c3fb2a6b02fc417ad45d7d22ca6795457
Gerrit-Change-Number: 41732
Gerrit-PatchSet: 3
Gerrit-Owner: Jonathan Zhang jonzhang@fb.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Johnny Lin Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 29 May 2020 01:32:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment