[coreboot-gerrit] Change in coreboot[master]: src/{include/acpi,mainboard}: Introduce CURRENT_DSDT_REV macro

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45751 )

Change subject: src/{include/acpi,mainboard}: Introduce CURRENT_DSDT_REV macro
......................................................................

Patch Set 3:

(1 comment)
> Patch Set 3:
> > Patch Set 3:
> >
> > And btw: You seem to have missed at least src/mainboard/supermicro/x10slm-f/dsdt.asl as this file have the header defined on one line which was not caught by your regexp.
>
> And src/mainboard/asus/p2b/dsdt.asl, same here.

please see https://review.coreboot.org/c/coreboot/+/45791/1

https://review.coreboot.org/c/coreboot/+/45751/3/src/include/acpi/acpi.h 
File src/include/acpi/acpi.h:

https://review.coreboot.org/c/coreboot/+/45751/3/src/include/acpi/acpi.h@44 
PS3, Line 44: #define CURRENT_DSDT_REV	0x02        /* DSDT revision: ACPI v2.0 and greater */
> So we've been copy-pasting the wrong DSDT revision all the time?

DSDT revision is not ACPI_FADT_REV_ACPI_xx...