13 Jul
2020
13 Jul
'20
11:23 a.m.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43410 )
Change subject: mb/51nb/x210/gpio: Convert configuration to macros ......................................................................
Patch Set 3:
thinking out loud: would it make more sense to drop the invalid config bits from the raw values first, then convert the "corrected" raw values to macros cleanly?
--
To view, visit https://review.coreboot.org/c/coreboot/+/43410
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I18c0c321561eee04ff927681b0a231f6d79c63e2
Gerrit-Change-Number: 43410
Gerrit-PatchSet: 3
Gerrit-Owner: Maxim Polyakov max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 13 Jul 2020 17:23:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment