Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45459 )
Change subject: soc/intel/tigerlake: log the memory part name
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45459/4/src/lib/spd_bin.c
File src/lib/spd_bin.c:
https://review.coreboot.org/c/coreboot/+/45459/4/src/lib/spd_bin.c@139
PS4, Line 139: spd_dram_part_name
suggestion: spd_dram_part_name_override
https://review.coreboot.org/c/coreboot/+/45459/4/src/lib/spd_bin.c@148
PS4, Line 148: strlen(spd_dram_part_name)
If spd_dram_part_name is never set, then it will be NULL and strlen() will deref the NULL pointer
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45459
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I91971e07c450492dbb0588abd1c3c692ee0d3bb0
Gerrit-Change-Number: 45459
Gerrit-PatchSet: 4
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Thu, 17 Sep 2020 17:03:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment