Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48262 )
Change subject: mb/emulation/qemu-q35: Add support for SMM_TSEG with parallel MP init ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48262/4/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-q35/cpu.c:
https://review.coreboot.org/c/coreboot/+/48262/4/src/mainboard/emulation/qem... PS4, Line 17: // *smm_save_state_size = sizeof(amd64_smm_state_save_area_t); : *smm_save_state_size = 0x400;
Do you want to add a comment about this? ;)
Hmm that should not have made it here ^^. With 64bit the stub size is larger than the AMD64 save state so a proper fix needs to be done in mp init code.