Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47259 )
Change subject: soc/intel/tigerlake: Update Kconfig for NEM Enhanced Mode
......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47259/14//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47259/14//COMMIT_MSG@9
PS14, Line 9: IA32_PQR_ASSOC (0xC8F) MSR's Bits[32:33] are used for mask selection
: when Kconfig COS_MAPPED_TO_MSB is selected. In cpu/Kconfig, if
: INTEL_CAR_NEM_ENHANCED is selected, in tigerlake/Kconfig, selecting
: COS_MAPPED_TO_MSB to ensure Bits[32:33] are used for mask selection.
This needs update now. […]
Can you please address this as well?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47259
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib6e041261cb8ca9c6e602935da4962aac0d9ece5
Gerrit-Change-Number: 47259
Gerrit-PatchSet: 15
Gerrit-Owner: Shreesh Chhabbi
shreesh.chhabbi@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shreesh Chhabbi
shreesh.chhabbi@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Raj Astekar
raj.astekar@intel.com
Gerrit-CC: Raj Astekar
raj.astekar@intel.corp-partner.google.com
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 11 Nov 2020 18:53:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment