Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38741 )
Change subject: soc/intel/cannonlake: Add tdc config for CML
......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38741/3/src/soc/intel/cannonlake/in...
File src/soc/intel/cannonlake/include/soc/vr_config.h:
https://review.coreboot.org/c/coreboot/+/38741/3/src/soc/intel/cannonlake/in...
PS3, Line 57: TDC
Can you make this comment say 'Thermal Design Current' so it is clear without needing to decode an acronym?
https://review.coreboot.org/c/coreboot/+/38741/3/src/soc/intel/cannonlake/vr...
File src/soc/intel/cannonlake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/38741/3/src/soc/intel/cannonlake/vr...
PS3, Line 558: 1
Should this always be enabled or is there a reason a mainboard might want it disabled?
https://review.coreboot.org/c/coreboot/+/38741/3/src/soc/intel/cannonlake/vr...
PS3, Line 559:
extra newline
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38741
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4b17e5b4ce41c1adb436ae5646f0d8578a440e8
Gerrit-Change-Number: 38741
Gerrit-PatchSet: 3
Gerrit-Owner: Marx Wang
marx.wang@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Marx Wang
marx.wang@intel.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 12 Feb 2020 10:51:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment