Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38706 )
Change subject: security/vboot: relocate vb2ex_abort and vb2ex_printf ......................................................................
Patch Set 6: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/38706/6/src/security/vboot/Makefile... File src/security/vboot/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/38706/6/src/security/vboot/Makefile... PS6, Line 61: verstage-y += vboot_lib.c nit: There's no need to put this down here, the verstage class won't be used by any rules when not building for vboot but it doesn't hurt to still add files to it. I think it's more easy to read if you always put the lines of all classes for the same file together. (In fact, I've frequently thought we should add an 'all' class as a shorthand for all that library code that we want available everywhere, but that's one of those things you never actually end up finding time for.)
https://review.coreboot.org/c/coreboot/+/38706/6/src/security/vboot/vboot_li... File src/security/vboot/vboot_lib.c:
https://review.coreboot.org/c/coreboot/+/38706/6/src/security/vboot/vboot_li... PS6, Line 4: * Copyright 2020 The Chromium OS Authors. All rights reserved.
we should move to the spdx headers for copyright. Grep for SPDX-License-Identifer for an example.
I'm somewhat confused what's going on there actually, I thought the plan was to migrate whole directories at a time (so not every patch author needs to worry about it until their directory was migrated and the linter starts reminding them to), but it seems like nothing is happening anymore... (same as with the 96 character thing).
https://review.coreboot.org/c/coreboot/+/38706/6/src/security/vboot/vboot_li... PS6, Line 20: /* vboot_reference callbacks implemented by coreboot. */ nit: maybe be a bit more specific what separates these callbacks from the one implemented in vboot_logic.c?