Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45756 )
Change subject: mb/google/zork: de-assert eMMC RST for Morphius ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45756/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45756/1//COMMIT_MSG@9 PS1, Line 9: de-assert eMMC RST (GPIO68) to prevent eMMC abnormal. We don't really use this signal. Probably configure it as PAD_NC in baseboard/gpio_baseboard_trembyle.c?
https://review.coreboot.org/c/coreboot/+/45756/1//COMMIT_MSG@11 PS1, Line 11: 169211959 Did you mean: 169222156?
https://review.coreboot.org/c/coreboot/+/45756/1//COMMIT_MSG@14 PS1, Line 14: check GPIO86 state is PU What is the difference from a functional standpoint? Are you seeing some error go away because of this change?