View Change
3 comments:
Commit Message:
Patch Set #1, Line 9: de-assert eMMC RST (GPIO68) to prevent eMMC abnormal.
We don't really use this signal. Probably configure it as PAD_NC in baseboard/gpio_baseboard_trembyle.c?
Patch Set #1, Line 11: 169211959
Did you mean: 169222156?
Patch Set #1, Line 14: check GPIO86 state is PU
What is the difference from a functional standpoint? Are you seeing some error go away because of this change?
To view, visit change 45756. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9feb826eec8a8cdad5e2bd7efcbb1dcf96185dfd
Gerrit-Change-Number: 45756
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu <Kevin.Chiu@quantatw.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya@google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Keith Tzeng <keith.tzeng@quanta.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Sat, 26 Sep 2020 13:31:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment