Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42964 )
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad
......................................................................
Patch Set 21:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42964/21/src/mainboard/google/volte...
File src/mainboard/google/volteer/variants/volteer/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42964/21/src/mainboard/google/volte...
PS21, Line 20: .speed = I2C_SPEED_FAST,
: .speed_config[0] = {
: .speed = I2C_SPEED_FAST,
: .scl_lcnt = 163,
: .scl_hcnt = 75,
: .sda_hold = 36,
this section still needs more indentation.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42964
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If26bfdd319a80ed2484e5a2cda642c11385de671
Gerrit-Change-Number: 42964
Gerrit-PatchSet: 21
Gerrit-Owner: Johnny Li
johnny_li@wistron.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 10 Jul 2020 01:05:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment