Attention is currently required from: Angel Pons. Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41393 )
Change subject: util: add a tool to dump and insert MEC1322 firmware ......................................................................
Patch Set 4:
(5 comments)
File util/mec1322/mec1322.c:
https://review.coreboot.org/c/coreboot/+/41393/comment/d4dc5f93_a4871ebe PS3, Line 19: image
ec_fw ?
Done
https://review.coreboot.org/c/coreboot/+/41393/comment/14a953ca_f6d2d2e3 PS3, Line 44: const uint8_t CRC_TABLE[] = {0x00, 0x07, 0x0e, 0x09, 0x1c, 0x1b, 0x12, 0x15, : 0x38, 0x3f, 0x36, 0x31, 0x24, 0x23, 0x2a, 0x2d};
nit: place the values in a new line? […]
Done
https://review.coreboot.org/c/coreboot/+/41393/comment/87b87828_50af95f7 PS3, Line 79: 32
#define this?
Done
https://review.coreboot.org/c/coreboot/+/41393/comment/1fd4bcde_b0fc2436 PS3, Line 82: 256
#define this?
Done
https://review.coreboot.org/c/coreboot/+/41393/comment/ff3a1036_39538d14 PS3, Line 152: fwTag
nit: fw_tag
Done