Attention is currently required from: Rizwan Qureshi, Tim Wawrzynczak, Angel Pons, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55225 )
Change subject: soc/intel/alderlake/romstage: Refactor soc_memory_init_params function ......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/alderlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/55225/comment/48f15146_d48539b5 PS1, Line 320: /* Fill IGD related FSP-M UPDs */ : fill_igd_memory_init_params(m_cfg, config); : : /* Fill Memory related FSP-M UPDs */ : fill_memory_memory_init_params(m_cfg, config); : : /* Fill CPU related FSP-M UPDs */ : fill_cpu_memory_init_params(m_cfg, config); : : /* Fill security related FSP-M UPDs */ : fill_security_memory_init_params(m_cfg); : : /* Fill UART debug related FSP-M UPDs */ : fill_uart_memory_init_params(m_cfg); : : /* Fill IPU related FSP-M UPDs */ : fill_ipu_memory_init_params(m_cfg); : : /* Fill SMBUS related FSP-M UPDs */ : fill_smbus_memory_init_params(m_cfg); : : /* Fill Miscellaneous FSP-M UPDs */ : fill_misc_memory_init_params(m_cfg, config); : : /* Fill Audio related FSP-M UPDs */ : fill_audio_memory_init_params(m_cfg, config); : : /* Fill PCIE related RP FSP-M UPDs */ : fill_pcie_rp_memory_init_params(m_cfg, config); : : /* Fill ISH related FSP-M UPD */ : fill_ish_memory_init_params(m_cfg); : : /* Fill TCSS related FSP-M UPD */ : fill_tcss_memory_init_params(m_cfg); : : /* Fill USB4/TBT related FSP-M UPD */ : fill_usb4_memory_init_params(m_cfg); : : /* Fill VT-d related FSP-M UPD */ : fill_vtd_memory_init_params(m_cfg); : : /* Fill trace related FSP-M UPD */ : fill_trace_memory_init_params(m_cfg);
I don't think we need a comment on every function call. […]
Thanks Angel for awesome feedback, i will adhere to this and it make sense to me as well