Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39959 )
Change subject: nb/intel/gm45: Simplify GMA SSDT generator
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/39959/2/src/northbridge/intel/gm45/...
File src/northbridge/intel/gm45/gma.c:
https://review.coreboot.org/c/coreboot/+/39959/2/src/northbridge/intel/gm45/...
PS2, Line 222: device
dev
https://review.coreboot.org/c/coreboot/+/39959/2/src/northbridge/intel/gm45/...
PS2, Line 225: chip
is chip null?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39959
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ideddfc3d327c4421faffb6583e347cd2b094e155
Gerrit-Change-Number: 39959
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 31 Mar 2020 11:07:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment