Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49055 )
Change subject: soc/intel/tigerlake: Add Kconfig options for each platform
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/49055/3/src/mainboard/intel/tglrvp/...
File src/mainboard/intel/tglrvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/49055/3/src/mainboard/intel/tglrvp/...
PS3, Line 16: select SOC_INTEL_TIGERLAKE_IOT if BOARD_INTEL_TGLRVP_UP3
: select SOC_INTEL_TIGERLAKE_CLIENT if BOARD_INTEL_TGLRVP_UP4
From the FSP `README.md`:
Client | Processors for client platforms
TGL_IOT | UP3-Series processors for IoT platforms
Does this mean we have to always use `TGL_IOT` with UP3? or are
there UP3 that should use the `Client` version?
In the former case, we could make this SOC_INTEL_TIGERLAKE_UP[34].
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49055
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I575f28c7eaa82ed5d52ba7c9328a52e76d71dc5b
Gerrit-Change-Number: 49055
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nathaniel L Desimone
nathaniel.l.desimone@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 03 Jan 2021 15:26:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment