Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31306 )
Change subject: device/pci_ops: Apply some symmetry in headers
......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2: Code-Review+2
would be great to fix some of that other arch deps. I assume there's a big ripple?
I assume you refer to the FIXME comment there? I can do some sed-magic if we agree <device/pci_ops.h> is the one to add and <arch/io.h> one to (sometimes) remove from includes.
Ya. I think arch/io should really not be in anything unless it is truly arch specific (io port access). All the memory mapped forced reads using volatile should really be arch agnostic. Either way, I like the direction the patches are taking.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31306
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8076a4867fd7472beaae0a021dcf0d9c7c905871
Gerrit-Change-Number: 31306
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 11 Feb 2019 16:11:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment