[coreboot-gerrit] Change in coreboot[master]: mb/google/dedede Add Audio support for waddledoo

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39285 )

Change subject: mb/google/dedede Add Audio support for waddledoo
......................................................................

Patch Set 8:

(2 comments)

https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... 
PS8, Line 101: PLTRST
> Why?

We can move it to deep, I thought the SPK Enable reset on PLTRST should not break any functionality and would get reconfigured in ramstage prior to boot beep requirement.

https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... 
PS8, Line 41: .scl_lcnt = 176,
            : 				.scl_hcnt = 95,
            : 				.sda_hold = 36,
> Were these verified?

Audio is verified working, but these parameters are not electrically verified. Will verify and update.