Attention is currently required from: Shelley Chen, Ravi kumar. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45206 )
Change subject: herobrine : Provide initial mainboard support ......................................................................
Patch Set 22:
(3 comments)
File src/mainboard/google/herobrine/Kconfig:
https://review.coreboot.org/c/coreboot/+/45206/comment/ced1bae2_50197190 PS22, Line 50: onfig GBB_HWID : string : depends on CHROMEOS : default "HEROBRINE TEST 1859" if BOARD_GOOGLE_HEROBRINE
I do not believe that we define HWID in Kconfig anymore, though I'm not sure where we actually do it […]
Yes, this will get auto-generated correctly now, just leave it out here.
File src/mainboard/google/herobrine/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45206/comment/4b2518fb_a8d0ecf4 PS22, Line 6: bootblock-y += reset.c
do we need to add reset. […]
For utility functions like board_reset() we often just add it everywhere rather than worry about where exactly it's needed. The linker will figure out where it is actually referenced and not include it in stages where it isn't, so there's no harm in that. It makes things easier if later changes want to call it from a different stage.
BTW, the Makefile system now supports `all-y += reset.c` as a shorthand for adding it to each stage individually, we should use that for files like this.
File src/mainboard/google/herobrine/board.h:
https://review.coreboot.org/c/coreboot/+/45206/comment/73b25208_28f4a45a PS22, Line 10: #define GPIO_EC_IN_RW GPIO(118) : #define GPIO_AP_EC_INT GPIO(94) : #define GPIO_AP_SUSPEND GPIO(20) : #define GPIO_WP_STATE GPIO(42) : #define GPIO_H1_AP_INT (CONFIG(TROGDOR_REV0) ? GPIO(21) : GPIO(42)) : #define GPIO_SD_CD_L GPIO(69) : #define GPIO_AMP_ENABLE GPIO(23) : : /* Display specific GPIOS */ : #define GPIO_BACKLIGHT_ENABLE GPIO(12) : #define GPIO_EDP_BRIDGE_ENABLE (CONFIG(TROGDOR_REV0) ? GPIO(14) : GPIO(104)) : #define GPIO_EN_PP3300_DX_EDP (CONFIG(TROGDOR_REV0) ? GPIO(106) : GPIO(30))
Seems like these have been copied from trodgor? Can you please make sure these are valid for herobr […]
Since there are no herobrine schematics yet (I think?) none of these are known yet. Just leave this file empty or remove it completely instead of copy&pasting stuff we know won't match... it can be added later.