Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38988 )
Change subject: mainboard: New ivybridge board ASUS P8Z77-M ......................................................................
Patch Set 5: Code-Review+1
(11 comments)
https://review.coreboot.org/c/coreboot/+/38988/4/src/mainboard/asus/p8z77-m/... File src/mainboard/asus/p8z77-m/Kconfig:
https://review.coreboot.org/c/coreboot/+/38988/4/src/mainboard/asus/p8z77-m/... PS4, Line 21: select INTEL_INT15
Want to test without this option?
This option is for the code in mainboard.c, which got removed. So, you should also remove this option here.
https://review.coreboot.org/c/coreboot/+/38988/5/src/mainboard/asus/p8z77-m/... File src/mainboard/asus/p8z77-m/acpi_tables.c:
https://review.coreboot.org/c/coreboot/+/38988/5/src/mainboard/asus/p8z77-m/... PS5, Line 8: pc PC
https://review.coreboot.org/c/coreboot/+/38988/5/src/mainboard/asus/p8z77-m/... PS5, Line 8: shutdown shut down
https://review.coreboot.org/c/coreboot/+/38988/5/src/mainboard/asus/p8z77-m/... PS5, Line 11: cpu CPU
https://review.coreboot.org/c/coreboot/+/38988/4/src/mainboard/asus/p8z77-m/... File src/mainboard/asus/p8z77-m/board_info.txt:
https://review.coreboot.org/c/coreboot/+/38988/4/src/mainboard/asus/p8z77-m/... PS4, Line 6: Flashrom support: ?
Needs kernel parameter iomem=relaxed. But it worked much faster than serprog on Arduino Mega.
Yes, bitbanging SPI is a bit slow. Even if iomem=relaxed is needed (another option is to unload some drivers, but I forget which), flashrom support should be `y`
https://review.coreboot.org/c/coreboot/+/38988/4/src/mainboard/asus/p8z77-m/... File src/mainboard/asus/p8z77-m/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38988/4/src/mainboard/asus/p8z77-m/... PS4, Line 14: # FIXME: check gfx.ndid and gfx.did : register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410 }" : register "gfx.ndid" = "3"
Could we do same to p8z77-m_pro? and fix its Win10 ACPI errors?
I did that on CB:39184
https://review.coreboot.org/c/coreboot/+/38988/5/src/mainboard/asus/p8z77-m/... File src/mainboard/asus/p8z77-m/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/38988/5/src/mainboard/asus/p8z77-m/... PS5, Line 4: // define ACPI_VIDEO_DEVICE _SB.PCI0.GFX0 Still there!
https://review.coreboot.org/c/coreboot/+/38988/4/src/mainboard/asus/p8z77-m/... File src/mainboard/asus/p8z77-m/early_init.c:
https://review.coreboot.org/c/coreboot/+/38988/4/src/mainboard/asus/p8z77-m/... PS4, Line 88: void mainboard_fill_pei_data(struct pei_data *pei_data)
Guard for bootblock or romstage?
I see the guards are not needed anymore.
https://review.coreboot.org/c/coreboot/+/38988/4/src/mainboard/asus/p8z77-m/... File src/mainboard/asus/p8z77-m/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/38988/4/src/mainboard/asus/p8z77-m/... PS4, Line 32: Internal
This entire list has been distilled after more testing. Turns out to be identical to p8z77-m_pro.
Ack
https://review.coreboot.org/c/coreboot/+/38988/5/src/mainboard/asus/p8z77-m/... File src/mainboard/asus/p8z77-m/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/38988/5/src/mainboard/asus/p8z77-m/... PS5, Line 12: FIXME Fixed already, I guess?
https://review.coreboot.org/c/coreboot/+/38988/5/src/mainboard/asus/p8z77-m/... PS5, Line 14: rear nit: it's a desktop mainboard, it is assumed that all video ports will be on its rear side