Patch set 5:Code-Review +1
11 comments:
File src/mainboard/asus/p8z77-m/Kconfig:
Patch Set #4, Line 21: select INTEL_INT15
Want to test without this option?
This option is for the code in mainboard.c, which got removed. So, you should also remove this option here.
File src/mainboard/asus/p8z77-m/acpi_tables.c:
PC
Patch Set #5, Line 8: shutdown
shut down
CPU
File src/mainboard/asus/p8z77-m/board_info.txt:
Patch Set #4, Line 6: Flashrom support: ?
Needs kernel parameter iomem=relaxed. But it worked much faster than serprog on Arduino Mega.
Yes, bitbanging SPI is a bit slow. Even if iomem=relaxed is needed (another option is to unload some drivers, but I forget which), flashrom support should be `y`
File src/mainboard/asus/p8z77-m/devicetree.cb:
# FIXME: check gfx.ndid and gfx.did
register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410 }"
register "gfx.ndid" = "3"
Could we do same to p8z77-m_pro? and fix its Win10 ACPI errors?
I did that on CB:39184
File src/mainboard/asus/p8z77-m/dsdt.asl:
Patch Set #5, Line 4: // define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0
Still there!
File src/mainboard/asus/p8z77-m/early_init.c:
Patch Set #4, Line 88: void mainboard_fill_pei_data(struct pei_data *pei_data)
Guard for bootblock or romstage?
I see the guards are not needed anymore.
File src/mainboard/asus/p8z77-m/gma-mainboard.ads:
Patch Set #4, Line 32: Internal
This entire list has been distilled after more testing. Turns out to be identical to p8z77-m_pro.
Ack
File src/mainboard/asus/p8z77-m/gma-mainboard.ads:
Patch Set #5, Line 12: FIXME
Fixed already, I guess?
nit: it's a desktop mainboard, it is assumed that all video ports will be on its rear side
To view, visit change 38988. To unsubscribe, or for help writing mail filters, visit settings.