Attention is currently required from: Nico Huber, Furquan Shaikh, Tim Wawrzynczak, Paul Menzel, Zhuohao Lee, Patrick Rudolph.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57069 )
Change subject: coreboot tables: Add type-c port info to coreboot table
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/volteer/mainboard.c:
https://review.coreboot.org/c/coreboot/+/57069/comment/b9a30788_91505cde
PS8, Line 99: struct drivers_intel_pmc_mux_conn_config *config = child->chip_info;
: if (config) {
: info[count].usb2_port_number = config->usb2_port_number;
: info[count].usb3_port_number = config->usb3_port_number;
: info[count].sbu_orientation = config->sbu_orientation;
: info[count].data_orientation = config->hsl_orientation;
: count++;
: }
WDYT about adding a function like here https://review.coreboot. […]
Is the new conn_get_type_c_list() sufficient for that purpose? If not, are there additional checks that should be added to conn_get_type_c_list() so that it serves the verify purpose?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57069
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ice732be2fa634dbf31ec620552b383c4a5b41451
Gerrit-Change-Number: 57069
Gerrit-PatchSet: 9
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 01 Sep 2021 05:18:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment