Attention is currently required from: Paul Menzel, Pablo Stebler. Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44750 )
Change subject: ec/hp/kbc1126: Wait a longer time after sending ......................................................................
Patch Set 4:
(3 comments)
Patchset:
PS4: The latest patch set only changes two constant values and don't have these code. I think we can merge this first.
File src/ec/hp/kbc1126/ec.c:
https://review.coreboot.org/c/coreboot/+/44750/comment/7c42d76c_f521f3c6 PS2, Line 121: int timeout = 0x17ff;
Please add a comment how many ms this is.
Ack
https://review.coreboot.org/c/coreboot/+/44750/comment/33a87f2f_8de7c43c PS2, Line 123: udelay(10);
Please use the stopwatch framework, and print he actual time spent.
Ack