[coreboot-gerrit] Change in ...coreboot[master]: sb/amd/agesa/hudson/Kconfig: Disable XHCI by default, enable only wit...

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30749 )

Change subject: sb/amd/agesa/hudson/Kconfig: Disable XHCI by default, enable only with firmware
......................................................................

Patch Set 4:
> Recently my friend Ivan told me that USB3 works at G505S, but only if you
> change at its' Kconfig from select SOUTHBRIDGE_AMD_AGESA_HUDSON to select SOUTHBRIDGE_AMD_AGESA_BOLTON - because G505S FCH is Bolton-M3, not Hudson

The different XHCI controller is the main difference between Hudson and Bolton.
> and also add the correct xHCI firmware (e.g. available at https://github.com/informer2016/shared_devfiles/blob/master/0.10.0_1022_7814... ) which has been extracted using Felix Held's fch_xhci_rom_dumper - https://github.com/felixheld/fch_xhci_rom_dumper - from G505S while it has been running the proprietary UEFI.

Huh, fch_xhci_rom_dumper is completely unrelated and not needed here, since it dumps the rom part of the firmware and not the runtime-loaded part. The right XHCI blob for bolton is in the blobs repo.