Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34449 )
Change subject: soc/intel/common: Set controller state to active in GSPI init
......................................................................
Patch Set 7:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34449/6/src/soc/intel/common/block/...
File src/soc/intel/common/block/gspi/gspi.c:
https://review.coreboot.org/c/coreboot/+/34449/6/src/soc/intel/common/block/...
PS6, Line 456: devfn < 0
Yes. Line 236 also shows check for devfn < 0.
Done
https://review.coreboot.org/c/coreboot/+/34449/6/src/soc/intel/common/block/...
PS6, Line 460: }
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/34449/6/src/soc/intel/common/block/...
PS6, Line 460:
tab ?
Done
https://review.coreboot.org/c/coreboot/+/34449/6/src/soc/intel/common/block/...
PS6, Line 460: }
please, no spaces at the start of a line
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34449
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2f95059453ca5565a38650b147590ece4d8bf5ed
Gerrit-Change-Number: 34449
Gerrit-PatchSet: 7
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 24 Jul 2019 03:16:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Meera Ravindranath
meera.ravindranath@intel.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Aamir Bohra
aamir.bohra@intel.com
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment