Matt Papageorge has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43303 )
Change subject: mb/amd,google/mandolin,zork: Set EFS SPI platform config
......................................................................
Patch Set 16:
Patch Set 9:
Please add to commit message that you have tested stoneyridge builds to not change.
While stoneyridge selects SOC_AMD_COMMON_BLOCK_SPI it does not actually call fch_spi_early_init() and the Makefiles were not modified to fill EFS. Even though support for fam15h was added to util/amdfwtool.
I have refactored the change as follows.
1. Kconfig changes
2. Build changes for picasso platforms
3. Build changes for stoney ridge platforms
An optional future 4th change would be to address the duplicate definition of this information in
mainboard/google/kahlee/bootblock/bootblock.c
mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb
mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43303
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I765dada14700f4800263d2d3844af07fad0e5b71
Gerrit-Change-Number: 43303
Gerrit-PatchSet: 16
Gerrit-Owner: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin Frodsham
justin.frodsham@amd.corp-partner.google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-Comment-Date: Tue, 28 Jul 2020 17:07:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment