Attention is currently required from: Bora Guvendik, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Li1 Feng, Pranava Y N.
Subrata Banik has posted comments on this change by Li1 Feng. ( https://review.coreboot.org/c/coreboot/+/86005?usp=email )
Change subject: fatcat-ish: disable UART0 RX
......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/google/fatcat/variants/fatcat/fw_config.c:
https://review.coreboot.org/c/coreboot/+/86005/comment/45a81031_aeebc5f5?usp... :
PS2, Line 421: /* GPP_D05: NC */
: PAD_NC(GPP_D05, NONE)
I updated problem statement, it happens when ISH switches is OFF, might be FPS is ON, or both are OFF. So inside FPS doesn't cover all cases.
Ack
https://review.coreboot.org/c/coreboot/+/86005/comment/0eef90aa_10372809?usp... :
PS2, Line 432: /* GPP_D05: ISH_UART0_RXD */
: PAD_CFG_NF(GPP_D05, NONE, DEEP, NF2),
We still have ISH log, just console doesn't accept input. With ISH PM enabled, anyway console doesn't pick up input most of the time because it's in LPM; not much impact from what I experienced.
Can you please mention the same in the commit msg as well to ensure we know thar ISH console won't be able to receive a response w/ this CL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86005?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic84f8ead6a1fd056e649edbb1471bcb913a0a09a
Gerrit-Change-Number: 86005
Gerrit-PatchSet: 3
Gerrit-Owner: Li1 Feng
li1.feng@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Li1 Feng
li1.feng@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Tue, 28 Jan 2025 08:58:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Li1 Feng
li1.feng@intel.com