Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44394 )
Change subject: mb/emulation/qemu-armv7: Add MMU support ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44394/2/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-armv7/bootblock.c:
https://review.coreboot.org/c/coreboot/+/44394/2/src/mainboard/emulation/qem... PS2, Line 25: MMU_CONF_SYMBOL(usb, DCACHE_OFF)
the benefit of having multiple IO regions is that you don't need to define the MMIO address again, y […]
I mean... it's just not what we've done on all the other platforms, honestly. We usually just have a <soc/addressmap.h> header to #define all those base addresses. This may have some performance advantage because when a function accesses a specific register the compiler can compute (base address + offset) at compile time, whereas memlayout symbols can only be resolved at runtime.
I would suggest to just follow the pattern used by the other platforms for consistency.