Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32458 )
Change subject: mediatek/mt8183: Init audio related clock ......................................................................
Patch Set 1:
(4 comments)
I
https://review.coreboot.org/#/c/32458/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32458/1//COMMIT_MSG@9 PS1, Line 9: and replace with ','
https://review.coreboot.org/#/c/32458/1//COMMIT_MSG@9 PS1, Line 9: hoping is this a typo or correct name?
https://review.coreboot.org/#/c/32458/1//COMMIT_MSG@10 PS1, Line 10: playback beep sound audio playback
https://review.coreboot.org/#/c/32458/1/src/soc/mediatek/mt8183/pll.c File src/soc/mediatek/mt8183/pll.c:
https://review.coreboot.org/#/c/32458/1/src/soc/mediatek/mt8183/pll.c@361 PS1, Line 361: setbits_le32 The comment gave 3 (hoping, intbus and infra) but here the settings only do 2 set (or 4 clocks).
I think it'll be more clear if you have some comments for which line is setting what.