Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42521 )
Change subject: [WIP] mb/pcengines/apu2: Switch to proper GPIO API
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42521/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42521/2//COMMIT_MSG@13
PS2, Line 13: takes advantage of this property.
I forgot to change the text here, and also did not push the dependencies now. The point is we already have some existing GPIO API we should utilise instead of going directly into the ACPIMMIO GPIO memory space under mb/ code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42521
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I348ba43a76287be5b24012ae3dfc28ed783da9c7
Gerrit-Change-Number: 42521
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Fri, 19 Jun 2020 10:27:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment