Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48115 )
Change subject: mb/google/brya: Add EC smihandler ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/48115/3/src/mainboard/google/brya/s... File src/mainboard/google/brya/smihandler.c:
https://review.coreboot.org/c/coreboot/+/48115/3/src/mainboard/google/brya/s... PS3, Line 10: void mainboard_smi_gpi_handler(const struct gpi_status *sts) : { : /* TODO: Process SMI events from GPI */ : } Are there plans for GPIO SMIs?
https://review.coreboot.org/c/coreboot/+/48115/3/src/mainboard/google/brya/s... PS3, Line 18: MAINBOARD_EC_S5_WAKE_EVENTS); fits on previous line (96 chars)
https://review.coreboot.org/c/coreboot/+/48115/3/src/mainboard/google/brya/s... PS3, Line 24: MAINBOARD_EC_SMI_EVENTS); fits on previous line (96 chars)