Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39823 )
Change subject: soc/intel/jasperlake: Add Jasper Lake SoC support
......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/c/coreboot/+/39823/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39823/1//COMMIT_MSG@14
PS1, Line 14: SOC_INTEL_TIGERLAKE_BASE
SOC_INTEL_TIGERLAKE_BASE_COPY ?
One could also use SOC_INTEL_JASPERLAKE_BASE
https://review.coreboot.org/c/coreboot/+/39823/1//COMMIT_MSG@16
PS1, Line 16: tgl
TGL
https://review.coreboot.org/c/coreboot/+/39823/1//COMMIT_MSG@16
PS1, Line 16: jsl
JSL
https://review.coreboot.org/c/coreboot/+/39823/1//COMMIT_MSG@18
PS1, Line 18: directive
plural: directives
https://review.coreboot.org/c/coreboot/+/39823/1//COMMIT_MSG@18
PS1, Line 18: compile time
add a hyphen: compile-time
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39823
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9c33f478a2f8ed5e2d8e7815821d13044d35d388
Gerrit-Change-Number: 39823
Gerrit-PatchSet: 1
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 25 Mar 2020 14:00:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment