Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48407 )
Change subject: src/Kconfig: Select NO_CBFS_MCACHE if USE_OPTION_TABLE
......................................................................
Patch Set 1: Code-Review+2
Thanks for the fix!
I guess there are more CBFS-before-CBMEM issues than I thought. I think the best thing would probably be a general fix where the CBFS code doesn't try to access the mcache (and instead falls back to lookup on flash) when CBMEM is not available yet in these stages?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48407
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie5a2da8759323239adc758811cdbb4ba6e42fc9c
Gerrit-Change-Number: 48407
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 07 Dec 2020 20:45:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment