Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43949 )
Change subject: mb/google/dedede: Fix S3 wake using trackpad
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43949/4/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/43949/4/src/mainboard/google/dedede...
PS4, Line 52: DEEP
I can see that with Deep - Pad configuration is not reset in S3. […]
Yes, Karthik. We have verified it to be working fine on Doo, Dee and Drawlat for both S0ix and S3 scenarios.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43949
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I58ce3720e0fdeefb2c9440bb3006897ef80211ea
Gerrit-Change-Number: 43949
Gerrit-PatchSet: 4
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 30 Jul 2020 10:47:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment