Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45796 )
Change subject: soc/intel: Make use of PMC low power program from common block ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45796/3/src/soc/intel/cannonlake/fi... File src/soc/intel/cannonlake/finalize.c:
https://review.coreboot.org/c/coreboot/+/45796/3/src/soc/intel/cannonlake/fi... PS3, Line 43: static void pch_finalize(void)
These functions are still rather similar between SoCs.
Yes Angel, only because of CNL platform, right now i'm unable to move this code into common, bt will address this during common code phase 2.0 that we are planning before EOY.