Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42911 )
Change subject: soc/intel/common/gpio_defs: Improve some GPI macros
......................................................................
Patch Set 9:
(1 comment)
Patch Set 8: Code-Review+2
Thanks for the review
(1 comment)
These macros aren't used as of now, right?
Yes, there are no boards in the master that use these macros, but this is needed for CB:39765
https://review.coreboot.org/c/coreboot/+/39765/27/src/mainboard/up/squared/g...
and CB:39133
https://review.coreboot.org/c/coreboot/+/39133/33/src/mainboard/kontron/mal1...
https://review.coreboot.org/c/coreboot/+/42911/8//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42911/8//COMMIT_MSG@15
PS8, Line 15: fileds
fields
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42911
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8a70a366e816d31720d341a5d26880dc32ff9b8d
Gerrit-Change-Number: 42911
Gerrit-PatchSet: 9
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 24 Jul 2020 21:04:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment