Alex Thiessen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30989 )
Change subject: intelblocks/systemagent: Add ACPI table generation hook ......................................................................
Patch Set 5: Code-Review+2
(3 comments)
https://review.coreboot.org/#/c/30989/1/src/soc/intel/common/block/systemage... File src/soc/intel/common/block/systemagent/systemagent.c:
https://review.coreboot.org/#/c/30989/1/src/soc/intel/common/block/systemage... PS1, Line 5: 2018
we already have the year 2019 :)
Done
https://review.coreboot.org/#/c/30989/3/src/soc/intel/common/block/systemage... File src/soc/intel/common/block/systemagent/systemagent.c:
https://review.coreboot.org/#/c/30989/3/src/soc/intel/common/block/systemage... PS3, Line 23: #include <intelblocks/acpi.h> : #include <soc/iomap.h> : #include "systemagent_def.h" : #include <soc/pci_devs.h>
Ups, sorry. Will update.
Done
https://review.coreboot.org/#/c/30989/4/src/soc/intel/common/block/systemage... File src/soc/intel/common/block/systemagent/systemagent.c:
https://review.coreboot.org/#/c/30989/4/src/soc/intel/common/block/systemage... PS4, Line 24:
Damn...not by intention. Need to concentrate on just one thing at a time, sorry.
Done